PHP.Core.OrderedDictionary+Enumerator not Serializable

[kripper]

This happens when using an asp_state server for storing sessions.
I believe it's a trivial bug, since it seems similar to one posted and resolved recently.

BTW, sessions get lost after refreshing the same script about 10 times (randomly). Any hint? I will try to check this in more detail.

Code: Select all

System.Runtime.Serialization.SerializationException: Type PHP.Core.OrderedDictionary+Enumerator is not marked as Serializable.
  at System.Runtime.Serialization.Formatters.Binary.BinaryCommon.CheckSerializable (System.Type type, ISurrogateSelector selector, StreamingContext context) [0x0002c] in /opt/imatronix/src/mono/mono-2.10.9/mcs/class/corlib/System.Runtime.Serialization.Formatters.Binary/BinaryCommon.cs:119
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteValue (System.IO.BinaryWriter writer, System.Type valueType, System.Object val) [0x00006] in /opt/imatronix/src/mono/mono-2.10.9/mcs/class/corlib/System.Runtime.Serialization.Formatters.Binary/ObjectWriter.cs:762
  at PhpArray__TypeMetadata.WriteObjectData (System.Runtime.Serialization.Formatters.Binary.ObjectWriter , System.IO.BinaryWriter , System.Object ) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteObject (System.IO.BinaryWriter writer, Int64 id, System.Object obj) [0x0011e] in /opt/imatronix/src/mono/mono-2.10.9/mcs/class/corlib/System.Runtime.Serialization.Formatters.Binary/ObjectWriter.cs:370
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteObjectInstance (System.IO.BinaryWriter writer, System.Object obj, Boolean isValueObject) [0x00062] in /opt/imatronix/src/mono/mono-2.10.9/mcs/class/corlib/System.Runtime.Serialization.Formatters.Binary/ObjectWriter.cs:303
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteQueuedObjects (System.IO.BinaryWriter writer) [0x00005] in /opt/imatronix/src/mono/mono-2.10.9/mcs/class/corlib/System.Runtime.Serialization.Formatters.Binary/ObjectWriter.cs:281
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteObjectGraph (System.IO.BinaryWriter writer, System.Object obj, System.Runtime.Remoting.Messaging.Header[] headers) [0x0001f] in /opt/imatronix/src/mono/mono-2.10.9/mcs/class/corlib/System.Runtime.Serialization.Formatters.Binary/ObjectWriter.cs:268
  at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize (System.IO.Stream serializationStream, System.Object graph, System.Runtime.Remoting.Messaging.Header[] headers) [0x0005f] in /opt/imatronix/src/mono/mono-2.10.9/mcs/class/corlib/System.Runtime.Serialization.Formatters.Binary/BinaryFormatter.cs:218
  at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize (System.IO.Stream serializationStream, System.Object graph) [0x00000] in /opt/imatronix/src/mono/mono-2.10.9/mcs/class/corlib/System.Runtime.Serialization.Formatters.Binary/BinaryFormatter.cs:197
  at PHP.Core.AspNetSessionHandler.Persist (PHP.Core.PhpArray variables, PHP.Core.ScriptContext context, System.Web.HttpContext httpContext) [0x00000] in <filename unknown>:0
  at PHP.Core.RequestContext.EndSession (Boolean abandon) [0x00000] in <filename unknown>:0
  at PHP.Core.RequestContext.<TryDisposeBeforeFinalization>b__0 (System.Object _) [0x00000] in <filename unknown>:0
  at PHP.Core.ScriptContext.GuardedCall[Object,Object] (System.Converter`2 routine, System.Object data, Boolean allowUserExceptions) [0x00000] in <filename unknown>:0


[Jakub Misek]

PHP.Core.OrderedDictionary+Enumerator will be fixed. Thanks.

[Jakub Misek]

Sessions are handled by ASP.NET if not configured differently. Phalanger just loads them into PHP global variable, and at the end of request it saves them back.

[kripper]

Tested latest SVN implementation and got this:

Code: Select all

System.ArgumentException: Value does not fall within the expected range.
  at PHP.Core.OrderedDictionary.CopyTo (System.Collections.Generic.KeyValuePair`2[] array, Int32 arrayIndex) [0x00000] in <filename unknown>:0
  at PHP.Core.OrderedDictionary.GetObjectData (System.Runtime.Serialization.SerializationInfo info, StreamingContext context) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.GetObjectData (System.Object obj, System.Runtime.Serialization.Formatters.Binary.TypeMetadata& metadata, System.Object& data) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteObject (System.IO.BinaryWriter writer, Int64 id, System.Object obj) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteObjectInstance (System.IO.BinaryWriter writer, System.Object obj, Boolean isValueObject) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteQueuedObjects (System.IO.BinaryWriter writer) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteObjectGraph (System.IO.BinaryWriter writer, System.Object obj, System.Runtime.Remoting.Messaging.Header[] headers) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize (System.IO.Stream serializationStream, System.Object graph, System.Runtime.Remoting.Messaging.Header[] headers) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize (System.IO.Stream serializationStream, System.Object graph) [0x00000] in <filename unknown>:0
  at PHP.Core.AspNetSessionHandler.Persist (PHP.Core.PhpArray variables, PHP.Core.ScriptContext context, System.Web.HttpContext httpContext) [0x00000] in <filename unknown>:0
  at PHP.Core.RequestContext.EndSession (Boolean abandon) [0x00000] in <filename unknown>:0
  at PHP.Core.RequestContext.<TryDisposeBeforeFinalization>b__0 (System.Object _) [0x00000] in <filename unknown>:0
  at PHP.Core.ScriptContext.GuardedCall[Object,Object] (System.Converter`2 routine, System.Object data, Boolean allowUserExceptions) [0x00000] in <filename unknown>:0


[Jakub Misek]

Thanks! Fixed. (CopyTo(KeyValuePair<IntStringKey, object>[],int) had invalid argument check, has to be '>' instead of '>=')

[kripper]

I changed code to:

Code: Select all

        public void CopyTo(KeyValuePair<IntStringKey, object>[] array, int arrayIndex)
        {
            if (array == null || arrayIndex < 0 || (arrayIndex + this.Count) > array.Length)
                throw new ArgumentException();

            using (var enumerator = GetFastEnumerator())
                while (enumerator.MoveNext())
                    array[arrayIndex++] = enumerator.Current;
        }


Now I'm getting this:

Code: Select all

EndSession Exception: System.NullReferenceException: Object reference not set to
 an instance of an object
  at PHP.Core.OrderedDictionary+FastEnumerator.MoveNext () [0x00000] in <filenam
e unknown>:0
  at PHP.Core.OrderedDictionary.CopyTo (System.Collections.Generic.KeyValuePair`
2[] array, Int32 arrayIndex) [0x00000] in <filename unknown>:0
  at PHP.Core.OrderedDictionary.GetObjectData (System.Runtime.Serialization.Seri
alizationInfo info, StreamingContext context) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.GetObjectData (
System.Object obj, System.Runtime.Serialization.Formatters.Binary.TypeMetadata&
metadata, System.Object& data) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteObject (Sy
stem.IO.BinaryWriter writer, Int64 id, System.Object obj) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteObjectInstance (System.IO.BinaryWriter writer, System.Object obj, Boolean isValueObject) [0x00000] in <filename unknown>:0
  at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.WriteQueuedObjects (System.IO.BinaryWriter writer) [0x00000] in <filename unknown>:0


The exception is generated here:

Code: Select all

this.current = table.entries[next].KeyValuePair;


[Jakub Misek]

Thanks! This will be fixed as it will go to official release. Meantime it is in development and it is recommended to use release changeset.

[kripper]

Ok. One more hint:
In MoveNext() 'next' is 0 and 'table.entries' is null.

[Jakub Misek]

Thanks We will take a look on this ASAP.