Page 1 of 1

Facilitiate contribution

PostPosted: March 2nd, 2015, 11:48 pm
by davidbcn
Currently is is very difficult to contribute back to phalanger on GitHub because of the lack of documentation on the initial setup plus:

1. .csproj files are under Visual Studio source control. The first problem anyone faces is that these project files will simply not open. VS Source control should be completely removed from the .csproj files in GitHUB.

2. Deploymnent commands are failing on VS2103 (don't know about other versions). But, why rely on GAC to deploy?

During development the GAC assemblies get blocked and updating them is a mess. Using direct path to DLL from web.config is better and more reliable. Personally, I'd remove deployment commands except copying the dll's to the "\Phalanger\Deployment\Debug" directory. The web appliaations can reference the dll's in that directory directly.


Re: Facilitiate contribution

PostPosted: March 20th, 2015, 12:08 am
by diddledan
with regards to 1. I had no problems opening the solution file (the .sln file at `./Solutions/Phalanger.sln`, not one of the individual .csproj files - the .sln will open all the projects together) in VS2015-CTP6, though I've not yet tried in 2013.

and in relation to 2. I'm currently attempting to get my copy into a state where everything works via nuget. My work-in-progress is at (it's only showing a few initial commits from earlier today where I stripped some included dependencies and replaced them with nuget equivalents and added some nuspec files so that each project is built into a separate nuget package. I've not tested that anything is actually usable yet so I'm expecting I've completely broken things in my repo for now.)

Re: Facilitiate contribution

PostPosted: July 13th, 2016, 2:46 pm
by ts-micah
Hi guys,

Is there any way this could be pulled into the main branch and get published to It would be very similar to what Microsoft has done with the C# & VB compilers to introduce new language features - see Microsoft.Net.Compilers.

IMHO it would be much easier to manage and integrate with projects rather than the GAC.

Re: Facilitiate contribution

PostPosted: July 17th, 2016, 10:12 pm
by Jakub Misek

I would vote for Nuget packages. Please feel free to fork and make the package, we'll be happy to merge your changes to main distro. Just please keep the pull request small and clean.

Also - I would like to point to the successor of Phalanger that is made from scratch as a portable library on top of Roslyn, with much increased performance and interoperability options.

Re: Facilitiate contribution

PostPosted: July 17th, 2016, 10:28 pm
by diddledan
Thanks for the reminder. I'll see what I can whip-up from my github copy which I haven't checked in a while. I believe the only issue I'm facing at the moment is the automated insertion/removal of Phalanger-related configuration into the web.config in whichever project imports the nuget packages.

Re: Facilitiate contribution

PostPosted: July 19th, 2016, 8:21 pm
by diddledan
see pull request here with everything working correctly as far as I can tell.