Facilitiate contribution

Discussion about the open-source Phalanger [?] project.

Facilitiate contribution

Postby davidbcn » March 2nd, 2015, 11:48 pm

Currently is is very difficult to contribute back to phalanger on GitHub because of the lack of documentation on the initial setup plus:

1. .csproj files are under Visual Studio source control. The first problem anyone faces is that these project files will simply not open. VS Source control should be completely removed from the .csproj files in GitHUB.

2. Deploymnent commands are failing on VS2103 (don't know about other versions). But, why rely on GAC to deploy?

During development the GAC assemblies get blocked and updating them is a mess. Using direct path to DLL from web.config is better and more reliable. Personally, I'd remove deployment commands except copying the dll's to the "\Phalanger\Deployment\Debug" directory. The web appliaations can reference the dll's in that directory directly.

Greetings!
davidbcn
 
Posts: 87
Joined: September 10th, 2014, 3:07 am

Re: Facilitiate contribution

Postby diddledan » March 20th, 2015, 12:08 am

with regards to 1. I had no problems opening the solution file (the .sln file at `./Solutions/Phalanger.sln`, not one of the individual .csproj files - the .sln will open all the projects together) in VS2015-CTP6, though I've not yet tried in 2013.

and in relation to 2. I'm currently attempting to get my copy into a state where everything works via nuget. My work-in-progress is at http://github.com/diddledan/Phalanger (it's only showing a few initial commits from earlier today where I stripped some included dependencies and replaced them with nuget equivalents and added some nuspec files so that each project is built into a separate nuget package. I've not tested that anything is actually usable yet so I'm expecting I've completely broken things in my repo for now.)
User avatar
diddledan
 
Posts: 14
Joined: March 19th, 2015, 2:59 pm
Location: Hampshire, UK

Re: Facilitiate contribution

Postby ts-micah » July 13th, 2016, 2:46 pm

Hi guys,

Is there any way this could be pulled into the main branch and get published to nuget.org? It would be very similar to what Microsoft has done with the C# & VB compilers to introduce new language features - see Microsoft.Net.Compilers.

IMHO it would be much easier to manage and integrate with projects rather than the GAC.
User avatar
ts-micah
 
Posts: 2
Joined: March 15th, 2016, 4:45 pm
Location: Pennsylvania, USA

Re: Facilitiate contribution

Postby Jakub Misek » July 17th, 2016, 10:12 pm

Hi,

I would vote for Nuget packages. Please feel free to fork and make the package, we'll be happy to merge your changes to main distro. Just please keep the pull request small and clean.

Also - I would like to point to the successor of Phalanger that is made from scratch as a portable library on top of Roslyn, with much increased performance and interoperability options. https://github.com/iolevel/peachpie
Jakub Misek │ DEVSENSE s.r.o. │ Email: jakub@devsense.com
User avatar
Jakub Misek
 
Posts: 2058
Joined: January 4th, 2012, 2:42 pm
Location: Prague

Re: Facilitiate contribution

Postby diddledan » July 17th, 2016, 10:28 pm

Thanks for the reminder. I'll see what I can whip-up from my github copy which I haven't checked in a while. I believe the only issue I'm facing at the moment is the automated insertion/removal of Phalanger-related configuration into the web.config in whichever project imports the nuget packages.
User avatar
diddledan
 
Posts: 14
Joined: March 19th, 2015, 2:59 pm
Location: Hampshire, UK

Re: Facilitiate contribution

Postby diddledan » July 19th, 2016, 8:21 pm

see pull request here with everything working correctly as far as I can tell.

https://github.com/DEVSENSE/Phalanger/pull/59
User avatar
diddledan
 
Posts: 14
Joined: March 19th, 2015, 2:59 pm
Location: Hampshire, UK


Return to Phalanger project

Who is online

Users browsing this forum: No registered users and 1 guest

cron

User Control Panel

Login

Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 5 minutes)
Most users ever online was 62 on January 7th, 2012, 10:54 pm

Users browsing this forum: No registered users and 1 guest
Phalanger