(done) Implementing interface (through Suggestions) return t
5 posts
• Page 1 of 1
(done) Implementing interface (through Suggestions) return t
Hi,
Using the Suggestion icon to implement an interface in a class disregards the return types as defined in the interface.
Interface example:
When using implementing via Suggestion i only get the comment block (with return type specified), but without the actual return type declaration behind the function like this:
I was expecting something like this:
Also, a nice to have feature would be to have a option to in- or exclude the doc comments when using the Suggestions to auto-implement stuff and to in- or exclude the comment (//TODO: ) inside the empty function it generates.
PHP Tools 1.29.10924.2017
VS Enterprise 2017 15.8.2
Using the Suggestion icon to implement an interface in a class disregards the return types as defined in the interface.
Interface example:
- Code: Select all
interface ISomeInterface
{
public function someFunction() : string;
}
When using implementing via Suggestion i only get the comment block (with return type specified), but without the actual return type declaration behind the function like this:
- Code: Select all
/**
*
* @return string
*/
function someFunction()
{
// TODO: implement the function ISomeInterface::someFunction
}
I was expecting something like this:
- Code: Select all
function someFunction() : string
{
// TODO: implement the function ISomeInterface::someFunction
}
Also, a nice to have feature would be to have a option to in- or exclude the doc comments when using the Suggestions to auto-implement stuff and to in- or exclude the comment (//TODO: ) inside the empty function it generates.
PHP Tools 1.29.10924.2017
VS Enterprise 2017 15.8.2
- lvw
- Posts: 7
- Joined: September 6th, 2018, 2:52 pm
Re: Implementing interface (through Suggestions) return type
Thanks for the suggestion. Will be implemented in the next update. I'll keep you notified in this thread.
Jakub Misek │ DEVSENSE s.r.o. | @misekjakub │ jakub@devsense.com │
-
Jakub Misek - Posts: 2092
- Joined: January 4th, 2012, 2:42 pm
- Location: Prague
Re: Implementing interface (through Suggestions) return type
Here is a preview version with your suggested improvements. Please let us know how it works for you. The options can be found in Tools / Options - Text Editor / PHP / Advanced.
https://www.devsense.com/en/download
Thanks,
Jakub
https://www.devsense.com/en/download
Thanks,
Jakub
Jakub Misek │ DEVSENSE s.r.o. | @misekjakub │ jakub@devsense.com │
-
Jakub Misek - Posts: 2092
- Joined: January 4th, 2012, 2:42 pm
- Location: Prague
Re: (done) Implementing interface (through Suggestions) retu
Wow, this is some quick support you have going on !
Installed and tested; works like a charm! Thank you very much!
Installed and tested; works like a charm! Thank you very much!
- lvw
- Posts: 7
- Joined: September 6th, 2018, 2:52 pm
5 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 88 guests